FIX: [xmaker] uncovered position fix #1992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
c9s
commented
Apr 21, 2025
- add covered position metrics
- use uncovered position to place spread maker order
- return covered position for any trade
- add covered position metrics - use uncovered position to place spread maker order - return covered position for any trade
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the uncovered position logic and improves the readability of logger calls and subscription formatting in the xmaker strategy module. It also updates the spread maker logic to work with the uncovered position and adds new metrics for monitoring covered positions.
- Reformats multiple logger statements into a multi-line style for improved readability.
- Introduces new functions to compute covered and uncovered positions.
- Adjusts the spread maker order logic to use the uncovered position when generating orders.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/strategy/xmaker/strategy.go | Reformatting logger calls; adjusting parameter names and position calculations for hedge logic |
| pkg/strategy/xmaker/spreadmaker.go | Adding a new uncoveredPosition parameter and updating order formation logic |
| pkg/strategy/xmaker/metrics.go | Updates to metrics initialization with formatting consistency |
Comments suppressed due to low confidence (2)
pkg/strategy/xmaker/strategy.go:1998
- [nitpick] The function name 'getUncoverPosition' is slightly inconsistent with the parameter naming 'uncoveredPosition' used elsewhere. Consider renaming it to 'getUncoveredPosition' for clarity and consistency.
func (s *Strategy) getUncoverPosition() fixedpoint.Value {
pkg/strategy/xmaker/spreadmaker.go:91
- [nitpick] Using 'uncoveredPosition.Neg()' to derive the base value could be confusing. It might help to clarify the intent either with a more descriptive variable name or an inline comment explaining the transformation.
base := uncoveredPosition.Neg()
f0b7ef3 to
fd419b5
Compare
kbearXD
approved these changes
Apr 21, 2025
gx578007
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.