Skip to content

REFACTOR: [coinbase] Revise User/Market data stream connection logic #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

REFACTOR: [coinbase] Revise User/Market data stream connection logic #1987

merged 1 commit into from
Apr 24, 2025

Conversation

dboyliao
Copy link
Collaborator

@dboyliao dboyliao commented Apr 17, 2025 •
edited
Loading

Revise the logic of handlers for user/market data stream

  • A user data stream will by default subscribe to user channel and receive user order related events
  • Implement PrivateChannelSymbolSetter for a user data stream
    • The symbols to be subscribed for a user data stream is controlled by privateChannelSymbols.
  • Only query account balances for a user data stream

@dboyliao dboyliao force-pushed the dboy/coinbase-user-market-stream branch 5 times, most recently from 618ff83 to 00bbb32 Compare April 21, 2025 06:40
@dboyliao dboyliao marked this pull request as ready for review April 21, 2025 06:40
@dboyliao dboyliao force-pushed the dboy/coinbase-user-market-stream branch 3 times, most recently from 9a256d1 to 651adcb Compare April 21, 2025 07:08
@dboyliao dboyliao force-pushed the dboy/coinbase-user-market-stream branch from 651adcb to 6339ee1 Compare April 23, 2025 11:20
@dboyliao dboyliao merged commit e97aa86 into main Apr 24, 2025
3 checks passed
@dboyliao dboyliao deleted the dboy/coinbase-user-market-stream branch April 24, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

@kbearXD kbearXD kbearXD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dboyliao @c9s @kbearXD