FIX: [bitget] change MinTradeAmount and MaxTradeAmount types to string and handle conversion error #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng and handle conversion error
8a43c8e to
b9139c3
Compare
bailantaotao
approved these changes
Apr 11, 2025
gx578007
reviewed
Apr 11, 2025
| minQuantity = v | ||
| } else { | ||
| log.Warnf("fail to convert min trade amount %s for %s, setting it to 0: %v", s.MinTradeAmount, s.Symbol, err) | ||
| minQuantity = fixedpoint.NewFromFloat(0.0) |
There was a problem hiding this comment.
Maybe use the min fixedpoint like "1e-8"?
There was a problem hiding this comment.
Considering trading, I think 0 is a safer value to use as min amount.
gx578007
reviewed
Apr 11, 2025
| if v, err := fixedpoint.NewFromString(s.MaxTradeAmount); err == nil { | ||
| maxQuantity = v | ||
| } else { | ||
| log.Warnf("fail to convert max trade amount %s for %s, setting it to unlimited (Inf): %v", s.MaxTradeAmount, s.Symbol, err) |
There was a problem hiding this comment.
Could you hint the input s.MaxTradeAmount can overflow in the log message.
There was a problem hiding this comment.
I include the err in the log message.
It should be clear enough it's overflow or anything else that cause the parsing failure.
ycdesu
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.