REFACTOR: [dca2] remove PositionOpening state and merge two function into op… #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
pkg/strategy/dca2/state.go:169
- [nitpick] The logging message still references 'WaitToOpenPosition' even though the state transition now occurs in openPosition; consider updating it to match the current state flow.
s.logger.Info("[State] WaitToOpenPosition -> OpenPositionReady")
9c6e886 to
5e803d2
Compare
bailantaotao
approved these changes
Apr 11, 2025
dboyliao
approved these changes
Apr 11, 2025
ycdesu
approved these changes
Apr 11, 2025
gx578007
approved these changes
Apr 11, 2025
5e803d2 to
ad1e4d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…enPosition