FEATURE: [grid2] use UniversalCancelAllOrders #1967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9s
reviewed
Apr 9, 2025
pkg/strategy/grid2/strategy.go
Outdated
| // UseCancelAllOrdersApiWhenClose uses a different API to cancel all the orders on the market when closing a grid | ||
| UseCancelAllOrdersApiWhenClose bool `json:"useCancelAllOrdersApiWhenClose"` | ||
| // UniversalCancelAllOrdersWhenClose close all orders even though the orders don't belong to this strategy | ||
| UniversalCancelAllOrdersWhenClose bool `json:"universalCancelAllOrdersWhenClose"` |
c9s
approved these changes
Apr 9, 2025
gx578007
reviewed
Apr 9, 2025
pkg/strategy/grid2/strategy.go
Outdated
| } | ||
|
|
||
| return werr | ||
| bbgo.Sync(ctx, s) |
There was a problem hiding this comment.
Add a comment for why to Sync here?
There was a problem hiding this comment.
I will move it to closeGrid and add the comment.
d18e7b5 to
6c5d5b9
Compare
bailantaotao
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.