IMPROVE: [bitget] improve bitget time in force support #1960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narumiruna
approved these changes
Mar 28, 2025
gx578007
approved these changes
Mar 28, 2025
kbearXD
reviewed
Mar 28, 2025
| switch order.Type { | ||
| case types.OrderTypeLimitMaker: | ||
| req.Force(v2.OrderForcePostOnly) | ||
| case types.OrderTypeMarket: | ||
| // From the doc: It is invalid when orderType is market) |
There was a problem hiding this comment.
Should we return error here?
If someone submit order with market, stop limit, stop market, it will submit no price order ?
There was a problem hiding this comment.
i fixed it by assigning it to GTC
b659ddc to
09b7c72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IOC support on bitget