FEATURE: [sync] sync with backoff retry #1954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds retry logic with exponential backoff to the asynchronous time range queries for syncing data.
- Integrates the backoff library to handle transient query errors.
- Wraps the query call in a retry loop with a hard-coded maximum retry count.
Comments suppressed due to low confidence (2)
pkg/exchange/batch/time_range_query.go:67
- Logging each retry attempt may clutter logs if intermittent errors occur; consider logging only after the final retry failure.
log.WithError(err).Errorf("unable to query %T, error: %v", q.Type, err)
pkg/exchange/batch/time_range_query.go:74
- The maximum retries value of 32 is hard-coded; consider making it a configurable parameter to allow adjustments based on different deployment environments.
backoff.WithMaxRetries(backoff.NewExponentialBackOff(), 32),
kbearXD
approved these changes
Mar 27, 2025
narumiruna
approved these changes
Mar 27, 2025
bailantaotao
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.