Skip to content

REFACTOR: [xalign] refactor detector #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 4, 2024
Merged

REFACTOR: [xalign] refactor detector #1847

merged 14 commits into from
Dec 4, 2024

Conversation

c9s
Copy link
Owner

@c9s c9s commented Dec 2, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 641 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 652 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 689 BBG

@c9s c9s requested review from kbearXD and gx578007 December 3, 2024 04:27
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 744 BBG

@c9s c9s force-pushed the c9s/xalign/refactor-detector branch from 670dfc6 to 029bb0e Compare December 3, 2024 07:11
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 699 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 704 BBG


last := d.records[len(d.records)-1]
firstRecord := d.records[0]
sustainedDuration := last.Time.Sub(firstRecord.Time)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if there's only one record, does it matter?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't matter~

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 723 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 728 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 750 BBG

@c9s c9s force-pushed the c9s/xalign/refactor-detector branch from c654c79 to 9884307 Compare December 3, 2024 10:41
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 753 BBG

@c9s c9s force-pushed the c9s/xalign/refactor-detector branch from 9884307 to ee22f9a Compare December 3, 2024 10:42
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 758 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 764 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 811 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 824 BBG

@c9s c9s merged commit b48818e into main Dec 4, 2024
3 checks passed
@c9s c9s deleted the c9s/xalign/refactor-detector branch December 4, 2024 06:20
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 829 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x884c096f789cf9cdb8ca7c44305c519d18a9d5f3cdb90527da244a8c90bb09c4

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants