Skip to content

feature: add binance TRADE_LITE event #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2024
Merged

feature: add binance TRADE_LITE event #1840

merged 2 commits into from
Nov 29, 2024

Conversation

b1u3h4t
Copy link
Contributor

@b1u3h4t b1u3h4t commented Nov 28, 2024

@bbgokarma-bot
Copy link

Hi @b1u3h4t,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 271 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

--
If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best,
KarmaBot

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@b1u3h4t
Copy link
Contributor Author

b1u3h4t commented Nov 28, 2024

ethereum:0xd3D32712A94F111077D0893847b47580C4d692C9

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 291 BBG

c9s
c9s approved these changes Nov 29, 2024
View reviewed changes
Copy link
Owner

@c9s c9s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@1a8820d). Learn more about missing BASE report.
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
pkg/strategy/grid2/strategy.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1840   +/-   ##
=======================================
  Coverage        ?   23.16%           
=======================================
  Files           ?      636           
  Lines           ?    48221           
  Branches        ?        0           
=======================================
  Hits            ?    11171           
  Misses          ?    36241           
  Partials        ?      809
Files with missing lines Coverage Δ
pkg/exchange/binance/parse.go 19.58% <100.00%> (ø)
pkg/strategy/grid2/strategy.go 33.11% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a8820d...d1db1fd. Read the comment docs.

@c9s c9s merged commit 351a88c into c9s:main Nov 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

@kbearXD kbearXD kbearXD approved these changes

@gx578007 gx578007 Awaiting requested review from gx578007 gx578007 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@b1u3h4t @bbgokarma-bot @CLAassistant @c9s @kbearXD