Fix: [autobuy] fix error when bollinger settings is not set #1700
Conversation
|
Welcome back! @narumiruna, This pull request may get 219 BBG. |
|
Re-estimated karma: this pull request may get 229 BBG |
|
Re-estimated karma: this pull request may get 246 BBG |
| return nil | ||
| } | ||
|
|
||
| func (s *Strategy) Defaults() error { | ||
| if s.OrderType == "" { |
There was a problem hiding this comment.
order type needs to be aligned with the price type
if price type = taker, the default limit maker won’t work
There was a problem hiding this comment.
so add a warning here?
There was a problem hiding this comment.
how about if priceType = taker { then use normal limit order instead }
else { then use limit maker order as a default }
There was a problem hiding this comment.
the default order type should be "limit", because it would work for all the cases
There was a problem hiding this comment.
I will set the default order type to limit
15196ea to
1b06fcc
Compare
|
Re-estimated karma: this pull request may get 301 BBG |
|
Hi @narumiruna, Well done! 306 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0xdf9bc7b800e9dfb97597607eaa5df4b85b795c48eb139a56882c364b0b842536 Thank you for your contribution! |
No description provided.