FEATURE: [xmaker] support delayed hedge #1780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome back! @c9s, This pull request may get 286 BBG. |
|
Re-estimated karma: this pull request may get 291 BBG |
ycdesu
approved these changes
Oct 16, 2024
gx578007
reviewed
Oct 16, 2024
| @@ -1027,7 +1064,7 @@ func (s *Strategy) tryArbitrage(ctx context.Context, quote *Quote, makerBalances | |||
| return false, nil | |||
| } | |||
|
|
|||
| if qty.IsZero() { | |||
| if qty.IsZero() || s.makerMarket.IsDustQuantity(qty, sumPv.Price) { | |||
There was a problem hiding this comment.
Does qty.IsZero() become redundant? Or qty.IsZero() is a faster route for most cases?
gx578007
approved these changes
Oct 16, 2024
|
Hi @c9s, Well done! 306 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x7a7c0d562f9e5c5005e115c3150f467d977a06354acc4004648867391be23981 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.