Skip to content

call b.EmitNew() when new order is added into activeorderbook #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2024
Merged

call b.EmitNew() when new order is added into activeorderbook #1744

merged 1 commit into from
Sep 14, 2024

Conversation

lanphan
Copy link
Contributor

@lanphan lanphan commented Sep 14, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @lanphan, This pull request may get 207 BBG.

@codecov Codecov
Copy link

codecov bot commented Sep 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.11%. Comparing base (336dd7a) to head (1f8b2b3).
Report is 41 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
- Coverage   24.11%   24.11%   -0.01%     
==========================================
  Files         615      615              
  Lines       37447    37541      +94     
==========================================
+ Hits         9031     9052      +21     
- Misses      27621    27691      +70     
- Partials      795      798       +3
Files with missing lines Coverage Δ
pkg/bbgo/activeorderbook.go 26.01% <100.00%> (+0.30%) ⬆️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25a2203...1f8b2b3. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 216 BBG

@c9s c9s merged commit 80430fe into c9s:main Sep 14, 2024
4 of 5 checks passed
@bbgokarma-bot
Copy link

Hi @lanphan,

Well done! 221 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x26f263da8741701ef84fce0f1e2b3184089d774f3a43a999b6ca0b1fc8d7f583

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lanphan @bbgokarma-bot @c9s