FEATURE: improve trade/order converter #1690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome back! @c9s, This pull request may get 353 BBG. |
gx578007
reviewed
Aug 9, 2024
pkg/core/tradecollector.go
Outdated
|
|
||
| func (c *ConverterManager) Initialize() error { | ||
| for _, converter := range c.Converters { | ||
| _ = converter |
There was a problem hiding this comment.
What's the purpose of this for loop?
kbearXD
approved these changes
Aug 9, 2024
bailantaotao
approved these changes
Aug 9, 2024
narumiruna
approved these changes
Aug 9, 2024
|
Re-estimated karma: this pull request may get 390 BBG |
|
Re-estimated karma: this pull request may get 409 BBG |
|
Re-estimated karma: this pull request may get 461 BBG |
|
Hi @c9s, Well done! 476 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x8bb2f00d985181d8fcbafd4f96764700d7485d1995bd0c71d7f3a38f6995bbe2 Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.