Skip to content

FEATURE: merge recover logic and run periodically #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2024
Merged

FEATURE: merge recover logic and run periodically #1383

merged 1 commit into from
Jul 1, 2024

Conversation

kbearXD
Copy link
Collaborator

@kbearXD kbearXD commented Nov 1, 2023

No description provided.

@kbearXD kbearXD requested a review from c9s November 1, 2023 05:48
@kbearXD kbearXD requested a review from gx578007 as a code owner November 1, 2023 05:48
@bbgokarma-bot
Copy link

Welcome back! @kbearXD, This pull request may get 335 BBG.

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 98 lines in your changes missing coverage. Please review.

Project coverage is 20.94%. Comparing base (396ee68) to head (b2c3d50).
Report is 2 commits behind head on main.

❗ Current head b2c3d50 differs from pull request most recent head 3735499

Please upload reports for the commit 3735499 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1383      +/-   ##
==========================================
- Coverage   22.77%   20.94%   -1.84%     
==========================================
  Files         622      568      -54     
  Lines       44809    40827    -3982     
==========================================
- Hits        10204     8550    -1654     
+ Misses      33865    31644    -2221     
+ Partials      740      633     -107
Files Coverage Δ
pkg/strategy/grid2/active_order_recover.go 41.33% <ø> (+41.33%) ⬆️
pkg/strategy/grid2/twin_order.go 47.53% <0.00%> (+1.14%) ⬆️
pkg/strategy/grid2/strategy.go 33.37% <0.00%> (+0.04%) ⬆️
pkg/strategy/grid2/recover.go 13.57% <0.00%> (-4.62%) ⬇️

... and 311 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad5674d...3735499. Read the comment docs.

@kbearXD kbearXD force-pushed the feature/grid2/merge-recover branch from b2c3d50 to 526d6c5 Compare November 6, 2023 07:18
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 342 BBG

@c9s
Copy link
Owner

c9s commented Nov 18, 2023

@kbearXD conflicts

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kbearXD kbearXD force-pushed the feature/grid2/merge-recover branch from 526d6c5 to 03aece8 Compare June 27, 2024 08:11
@kbearXD kbearXD force-pushed the feature/grid2/merge-recover branch from 03aece8 to 3735499 Compare June 27, 2024 12:32
@kbearXD kbearXD merged commit 1fe0ddb into main Jul 1, 2024
@kbearXD kbearXD deleted the feature/grid2/merge-recover branch July 1, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c9s c9s c9s approved these changes

@gx578007 gx578007 Awaiting requested review from gx578007 gx578007 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbearXD @bbgokarma-bot @c9s @CLAassistant