Skip to content

Conversation

cyfdecyf
Copy link

@cyfdecyf cyfdecyf commented May 23, 2022

Describe the changes

In check_task_monitoring, the check pattern should be

  1. release
  2. sleep
  3. print
  4. check

There's one test which has release and check immediately following which can result test failure.

Also added some blank lines to make the pattern easier to spot.

Testing

Have you tested the new code using the provided automated test program thread_pool_test.cpp and/or performed any other tests to ensure that it works correctly? If so, please provide information about the test system(s):

  • CPU model, architecture, # of cores and threads: Intel Core i5-8259U Processor, 4 core 8 threads
  • Operating system: macOS, Monterey
  • Name and version of C++ compiler: Apple clang version 13.1.6 (clang-1316.0.21.2.5)
  • Full command used for compiling, including all compiler flags: I'm using CMakeLists.txt.

@bshoshany
Copy link
Owner

Thanks, I must have gotten confused there! I will incorporate this fix into v3.0.0, which will hopefully be released in the next few days.

@bshoshany bshoshany closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants