fix(defaults): increase PASSES to a value greater than 10 for security #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also documents the change and adds a reference to the attack paper.
|
That attack paper's been around for a while, but the default time cost in https://github.com/p-h-c/phc-winner-argon2 is still set to 3. Would you mind raising this on their issue tracker too? I think they could offer some perspective on the legitimacy of this attack. Thanks! |
|
According to P-H-C/phc-winner-argon2#182, this can be closed? |
|
Seems like it. |
|
Amusing that Wikipedia linked to these issues mentioning "Argon2 engineers do not recommend that user implementations of Argon2 adjust the number of passes to be 10 or more." |
|
Alright, let's close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also documents the change and adds a reference to the attack paper.
Would it be reasonable to also make
Argon2::newfail with too few passes? While it would help enforcing better Argon2 configurations out in the wild, this would be a breaking change. Even a test breaking change for the already broken existing*_kattests.