Added monochrome CLI flag #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-rewerts
reviewed
Sep 29, 2018
interfacer/src/browsh/tty.go
Outdated
| @@ -16,6 +16,7 @@ var ( | |||
| uiHeight = 2 | |||
| // IsMonochromeMode decides whether to render the TTY in full colour or monochrome | |||
| IsMonochromeMode = false | |||
| color_mode = "true_color" | |||
There was a problem hiding this comment.
Could you remove this line until we do other color modes?
|
Nicely done! Works for me. I think when we implement other color modes, we might need to change to the flag, but this is an easy and clean merge! Btw I tested this out on Mac/Tmux and it works. @tombh Feel free to merge if you're okay with it. |
|
@j-rewerts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic --monochrome flag. Resolves part of Issue #187. I didn't add support for config mode.