Skip to content

Adding argument to keep site level filters in ReblockGVCFs #8304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 3, 2023
Merged

Adding argument to keep site level filters in ReblockGVCFs #8304

merged 3 commits into from
May 3, 2023

Conversation

meganshand
Copy link
Contributor

This keeps filters only on variants and removes all filters that would end up on RefBlocks (either from a low quality variant or other ref blocks in the input).

@meganshand meganshand requested a review from ldgauthier May 1, 2023 20:51
ldgauthier
ldgauthier approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@ldgauthier ldgauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Sorry you had to add another reblocking band-aid.

@meganshand meganshand merged commit ba483e3 into master May 3, 2023
@meganshand meganshand deleted the ms_reblock_filtering branch May 3, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ldgauthier ldgauthier ldgauthier approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meganshand @ldgauthier