fix(dockerfile): Use proxy env vars in aiohttp client requests #7260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@omriyoffe-panw yes, because I added a standard proxy support, and not used the entire env vars configurations. |
bo156
reviewed
Jul 27, 2025
bo156
approved these changes
Jul 27, 2025
yuvalmich
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all aiohttp requests to an existed wrapper.
Extended the wrapper to support different methods, get url as a URL type as well as str, and changed payload to optional (for GET requests).
In the wrapper, added usage of proxy env vars in order to avoid a bug a customer faced where its configured proxy env vars weren't in use in certain requests (the ones that were made using aiohttp lib).