Skip to content

Edge Case: Multiple Sockets and SetApplicationMenu can cause crash #180

@miketheprogrammer

Description

@miketheprogrammer

Assuming that we allow multiple thrust-clients to access one thrust-server, SetApplicationMenu is not destructor aware.

A base Thrust menu should take care of this, just swap and set once that destructor on the socket is called

Client 1 Connects
==> Opens window
==> Sets Application Menu
Client 2 Connects
==> Opens Window
Client 1 Disconnects
Browser User clicks menu item
Server ==> Send Event message (Socket no longer exists)
CRASH and FIRE and BOOOOOOM and People BURNING

**Edit
I should mention that I dont think your idea was to have multiple clients connecting to one server, but I figured I would report this anyway.

***Edit
If not self explanatory, Target platform is OSX because SetApplicationMenu is OSX Only,
This situation should not affect linux or windows, where menus are attached to the Window objects.
Only Application level menus should be affected by this.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions