Fix for stalled blog options on network activation #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wp-piwik-site_id
etc) - it's continuously requesting Matomo server viaWP_Piwik::requestPiwikSiteId()
trying to updatesite_id
, but blog option saved viaself::$settings->setOption ( 'site_id', $siteId );
is overridden then from$this->settings
in Settings::save()Also, in
TrackingCode::__construct()
it callsself::$wpPiwik->updateTrackingCode ()
with empty$siteId
and$blogId
paramsSuggested fix: use
get_current_blog_id()
when$blogID
is empty and removeelse
and always store local blog options in$this->settings
, maybe limited by condition liketo avoid any collisions..
2. Replace
add_blog_option()
withupdate_blog_option()
to update existing options3. Same for
add_site_option()
vsupdate_site_option()
inSettings::prepareTrackingCode()
4. Fix PHPDoc param order