Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bradleyfalzon/ghinstallation
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.2.0
Choose a base ref
...
head repository: bradleyfalzon/ghinstallation
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.3.0
Choose a head ref
  • 5 commits
  • 8 files changed
  • 3 contributors

Commits on Apr 7, 2023

  1. Allow JWT signing method to be configurable. 

    This change creates a new `Signer` interface which encapsulates
jwt.SigningMethod + the key material use to sign JWT tokens.

This allows clients to do is modify how JWT tokens are
signed by passing in their own Signer. In particular, I'm interested in
coupling this with something like
https://github.com/golang-jwt/jwt#extensions to allow for JWT signing
backed by KMS systems (Vault, Cloud KMS, etc).

Also introduces a new `AppsTransportOptions` to make it easier to make
new transport creation options without needing to make new funcs each
time. For now only added `WithSigner`, but we could easily extend this
out to other config options (Client, BaseURL, etc.)
    @wlynch
    wlynch committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    8121e40 View commit details
    Browse the repository at this point in the history

  2. Add blurb to README.md on signer customization.

    @wlynch
    wlynch committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    b3e558f View commit details
    Browse the repository at this point in the history

  3. HTTPError should be unwrappable. 

    Signed-off-by: Jakub Martin <kubam@spacelift.io>
    @cube2222 @wlynch
    cube2222 authored and wlynch committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    e386e62 View commit details
    Browse the repository at this point in the history

  4. Add test and comment. 

    Signed-off-by: Jakub Martin <kubam@spacelift.io>
    @cube2222 @wlynch
    cube2222 authored and wlynch committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    535c380 View commit details
    Browse the repository at this point in the history

  5. Bump github.com/google/go-github/v50 from 50.1.0 to 50.2.0 

    Bumps [github.com/google/go-github/v50](https://github.com/google/go-github) from 50.1.0 to 50.2.0.
- [Release notes](https://github.com/google/go-github/releases)
- [Commits](google/go-github@v50.1.0...v50.2.0)

---
updated-dependencies:
- dependency-name: github.com/google/go-github/v50
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot @wlynch
    dependabot[bot] authored and wlynch committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    217754f View commit details
    Browse the repository at this point in the history
Loading