Add Treetop Support - https://cjheath.github.io/treetop/ #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A DSL that integrates with Ruby for expressing a PEG (parsing expression grammer). The tool uses itself to define the language so if you really want the full details on the language it is at: https://github.com/cjheath/treetop/blob/master/lib/treetop/compiler/metagrammar.treetop But the cliff notes are: * Very Ruby-like * Only supports single-line comments * Embeds proper Ruby code so I just copy/pasted the complexitychecks from the Ruby language specs. To make this commit I just: 1. Added it to the `languages.json` file (per README) 2. Ran `go generate` (per README) 3. Ran `./test-all.sh`. This confirmed all green and updated `LANGAUGES.md` and `SCC-OUTPUT-REPORT.html` (maybe this step should be added to README?) I also ran `go build` to create the binary and tested it against my project which has many Treetop files and confirmed it worked.
|
One of the best PR's I have ever seen. Not only approved but noted as one for others to look at. Thank you very much! Will make the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A DSL that integrates with Ruby for expressing a PEG (parsing expression grammer). The tool uses itself to define the language so if you really want the full details on the language it is at:
https://github.com/cjheath/treetop/blob/master/lib/treetop/compiler/metagrammar.treetop
But the cliff notes are:
To make this commit I just:
languages.jsonfile (per README)go generate(per README)./test-all.sh. This confirmed all green and updatedLANGAUGES.mdandSCC-OUTPUT-REPORT.html(maybe this step should be added to README?)I also ran
go buildto create the binary and tested it against my project which has many Treetop files and confirmed it worked.