Skip to content

[cephes] use GTSAM_LIBRARY_TYPE #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2024
Merged

[cephes] use GTSAM_LIBRARY_TYPE #1942

merged 1 commit into from
Dec 23, 2024

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Dec 22, 2024 •
edited
Loading

Previously, when building GTSAM statically, my binaries still depended on libcephes-gtsamRelWithDebInfo.so.1 

matt@photonvision:~/Documents/GitHub/thirdparty-gtsam/build$ ldd meme
        linux-vdso.so.1 (0x00007ffcf8ff9000)
        libtbb.so.12 => /lib/x86_64-linux-gnu/libtbb.so.12 (0x000076020ab8f000)
        libtbbmalloc.so.2 => /lib/x86_64-linux-gnu/libtbbmalloc.so.2 (0x000076020ab4f000)
        libcephes-gtsamRelWithDebInfo.so.1 => /home/matt/Documents/GitHub/thirdparty-gtsam/build/_deps/gtsam-build/gtsam/3rdparty/cephes/libcephes-gtsamRelWithDebInfo.so.1 (0x000076020ab1d000)
        libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x000076020a800000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x000076020aa36000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x000076020a7e0000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x000076020a400000)
        /lib64/ld-linux-x86-64.so.2 (0x000076020af08000)

This PR would change cephes to use GTSAM_LIBRARY_TYPE, instead of hard-coding to SHARED. Not sure if there was a technical reason it was previously always SHARED - going back through the blame i dont see anything super obvious

varunagrawal
varunagrawal approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@varunagrawal varunagrawal merged commit 6f7365e into borglab:develop Dec 23, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcm001 @varunagrawal