Fixing strength of bias constraints in IMUKittiExampleGPS.cpp #1735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunagrawal
approved these changes
Mar 18, 2024
|
Looks like the PPA servers are down. I'll re-run the CI later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of a question at gtsam's Google group.
included_imu_measurement_countvariable was not zeroed making each consecutive bias constraint weaker. This PR zeroes it when a new node is placed in the graph. For default parameters,included_imu_measurement_countis equal to 100 for all added bias constraints.This change impacts the final estimate, which I am not sure if was ever compared to ground truth.
Previously, State at 469:
t: 43.0073055 74.1530101 -0.426735268Currently, State at 469:
t: 44.1523951 74.9626438 0.170519702