Specialize BetweenFactor with Similarity3 for Python bindings #1729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm, did not encounter the CI preprocessor error when I built locally. Will try to repro and fix next week. |
|
The issue in build is fixed by #1728. We'll try to land it ASAP and you can merge in the fix. |
|
just rebased on that, lets try running CI again |
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly trivial PR but I needed a
BetweenFactor<Similarity3>in Python so this adds the specialization in the interface file to be exported by wrap. I figured I'd post this here in case you want this upstream, but feel free to close if its not desired.