Skip to content

4.2 fixes #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 29, 2023
Merged

4.2 fixes #1425

merged 5 commits into from
Jan 29, 2023

Conversation

varunagrawal
Copy link
Contributor

  • Fixed warnings.
  • Updated CMake printing to be less verbose.
  • Made examples follow C++11 standards (instead of C++17).

I'll cherry-pick the first two fixes and make another PR targeting develop.

@varunagrawal varunagrawal requested a review from dellaert January 28, 2023 21:29
@varunagrawal varunagrawal self-assigned this Jan 28, 2023
@dellaert dellaert mentioned this pull request Jan 28, 2023
Merged
@varunagrawal
Copy link
Contributor Author

@dellaert merge and conflict fixes completed.

@dellaert
Copy link
Member

Canceling all but "required" CI - needs wheels to build.

@dellaert dellaert merged commit f09546f into release/4.2 Jan 29, 2023
@dellaert dellaert deleted the fixes branch January 29, 2023 00:37
@dellaert dellaert added this to the GTSAM 4.2 milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
GTSAM 4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert