fix ambiguous template variadic variable issue #1419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix fix ambiguous template variadic variable issue on non-gcc compilers https://stackoverflow.com/questions/56943558/c-partial-template-argument-deduction-for-function-with-variadic-pack-produces
ShuangLiu1992
added a commit
to ShuangLiu1992/gtsam
that referenced
this pull request
Jan 27, 2023
|
Thanks ! Let's wait for CI. |
dellaert
approved these changes
Jan 28, 2023
|
@ShuangLiu1992 I merged but still interested in answer about 4.2. Thanks for your contribution, regardless! |
|
I'm on 4.2 with clang and haven't received this error. We should still wait for @ShuangLiu1992 to report his results though. |
|
Actually, both are new methods added by Kartik and are not even in 4.2, so we can ignore. Thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix fix ambiguous template variadic variable issue on non-gcc compilers https://stackoverflow.com/questions/56943558/c-partial-template-argument-deduction-for-function-with-variadic-pack-produces