Simplified AP for HybridBayesNet #1372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTSAM suffers from having created many different "custom methods" in FactorGraph to add factors. It would be much nicer to be as close as possible to a std::vector. Since the hybrid API is still in complete beta, I am proposing to radically simplify, starting with
HybridBayesNet
, by getting rid of the non-standard methods in favor of:hbn.emplace_back(new GaussianMixture...));
hbn.emplace_back(new GaussianConditional...));
hbn.emplace_back(new DiscreteConditional...));
Adding shared pointers also works, should you need them somewhere else:
hbn.push_back(shared_ptr_to_a_conditional);
Note, in python things are automatically shared pointers, so there we always use push_back.
Similarly, we just use
at
:hbn.at(i).asMixture();
hbn.at(i).asGaussian();
hbn.at(i).asDiscrete();
@ProfFan was very helpful making this work.