Skip to content

Various fixes for Hybrid #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 4, 2023
Merged

Various fixes for Hybrid #1369

merged 6 commits into from
Jan 4, 2023

Conversation

varunagrawal
Copy link
Contributor

  • Enabled previously failing test.
  • Added check in GaussianMixtureFactor::likelihood.
  • Removed the confusing deferredFactors bit.
  • MixtureFactor::dim implementation.
  • Minor updates to HybridNonlinearISAM.

@varunagrawal varunagrawal requested a review from dellaert January 4, 2023 08:53
@varunagrawal varunagrawal self-assigned this Jan 4, 2023
dellaert
dellaert approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varunagrawal varunagrawal merged commit 78926f7 into hybrid/elimination Jan 4, 2023
@varunagrawal varunagrawal deleted the hybrid/various-fixes branch January 4, 2023 15:28
@dellaert dellaert added this to the Hybrid Inference milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
Hybrid Inference
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert