Skip to content

GaussianConditional logDeterminant #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2022
Merged

GaussianConditional logDeterminant #1345

merged 1 commit into from
Dec 23, 2022

Conversation

varunagrawal
Copy link
Contributor

Added logDeterminant and determinant methods to GaussianConditional to remove code duplication.

Need this to implement model selection cleanly in the hybrid case.

@varunagrawal varunagrawal added quick-review Quick and easy PR to review refactor Refactoring of code to remove rot labels Dec 23, 2022
@varunagrawal varunagrawal self-assigned this Dec 23, 2022
dellaert
dellaert approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, much cleaner. Will let you merge….

@varunagrawal varunagrawal merged commit 1ab922b into develop Dec 23, 2022
@varunagrawal varunagrawal deleted the varun/conditional-log-det branch December 23, 2022 14:30
@dellaert dellaert added this to the Hybrid Inference milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
quick-review Quick and easy PR to review refactor Refactoring of code to remove rot
Projects
None yet
Milestone
Hybrid Inference
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert