Break up Python CI steps so reading logs is easier #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To clarify, this is purely cosmetic, i.e. only separates the output into 2 different steps so that we can read it easier, but does not change the computation that occurs? Because one of the things I was thinking about was to split up the cpp compiling from the wrapper compiling so that cpp could be -j2 then switch wrapper to -j1, or something like that. But maybe that's not necessary since the swap space thing seems to have done the trick. |
gchenfc
approved these changes
Jul 27, 2022
|
Yeah any computation changes would be a follow up PR. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the Python CI run smaller steps so we're not inundated with information when debugging the CI.