Skip to content

Replace boost::function with std::function #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2022
Merged

Replace boost::function with std::function #1232

merged 2 commits into from
Jul 4, 2022

Conversation

varunagrawal
Copy link
Contributor

  1. Remove boost::function and replace with std::function. Still C++11 compliant.
  2. Add VectorSerialization to Point3 so that serialization works in downstream libraries.

@varunagrawal varunagrawal added the quick-review Quick and easy PR to review label Jul 3, 2022
@varunagrawal varunagrawal requested a review from ProfFan July 3, 2022 15:27
@varunagrawal varunagrawal self-assigned this Jul 3, 2022
@varunagrawal varunagrawal merged commit 33c9a34 into develop Jul 4, 2022
@varunagrawal varunagrawal deleted the remove-boost-function branch July 4, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

Assignees

@varunagrawal varunagrawal

Labels
quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @ProfFan