Add various tests for Hybrid #1220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfFan
approved these changes
Jun 10, 2022
| using symbol_shorthand::X; | ||
|
|
||
| /* ************************************************************************* */ | ||
| TEST(GaussianConditional, Equals) { |
There was a problem hiding this comment.
document the equations here (2 gaussians)
| TestResult tr; | ||
| return TestRegistry::runAllTests(tr); | ||
| } | ||
| /* ************************************************************************* */ |
|
|
||
| // TODO(Frank): why specify keys at all? And: keys in factor should be *all* | ||
| // keys, deviating from Kevin's scheme. Should we index DT on DiscreteKey? | ||
| // Design review! |
There was a problem hiding this comment.
the DiscreteKey is probably a suboptimal design, since that killed the consistency of API. I would argue that maybe in GTSAM 5 we should have the discrete values hold their cardinalities...
There was a problem hiding this comment.
Can you write up an issue for this? We're definitely going to forget in the far future. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled all the tests from the previous hybrid mechanism and updated them so they work.