Fix warnings and docs #1181
Merged
Fix warnings and docs #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
varunagrawal
commented
Apr 29, 2022
- Fix the warnings due to type mismatch in newly introduced methods.
- Update docs for IMU factors clarifying what frame the measurements are in.
jlblancoc
reviewed
Apr 29, 2022
gtsam/geometry/Pose2.cpp
Outdated
| @@ -365,7 +365,7 @@ boost::optional<Pose2> Pose2::Align(const Matrix& a, const Matrix& b) { | |||
| "Pose2:Align expects 2*N matrices of equal shape."); | |||
| } | |||
| Point2Pairs ab_pairs; | |||
| for (size_t j=0; j < a.cols(); j++) { | |||
| for (size_t j=0; j < size_t(a.cols()); j++) { | |||
There was a problem hiding this comment.
Thanks for the pr, I was also thinking of fixing them :-)
IMO, for C++ the C-type cast used here might be replaced by the more explicit static_cast.
That's in general. For these pair of warnings in particular I think it may make more sense to replace the loop counter variable from size_t to Eigen::Index, that should avoid casts at all and fix warnings, but haven't tried it yet...
There was a problem hiding this comment.
Great suggestion. I'll try them out and update!
There was a problem hiding this comment.
Eigen::Index works great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.