Skip to content

Add shared_ptr definition for remainder of camera objects #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2022
Merged

Add shared_ptr definition for remainder of camera objects #1088

merged 1 commit into from
Feb 5, 2022

Conversation

dwisth
Copy link
Contributor

@dwisth dwisth commented Feb 5, 2022

This is a minor usability fix.

Some of the camera calibration objects returned the expected shared_ptr e.g.

  • Cal3_S2Stereo::shared_ptr returns boost::shared_ptr<Cal3_S2Stereo>
  • Cal3Fisheye::shared_ptr returns boost::shared_ptr<Cal3Fisheye>

but others returned a different type which could be confusing, e.g.

  • Cal3DS2::shared_ptr returns boost::shared_ptr<Cal3>.

This PR adds some using statements to make this more consistent.

@dwisth dwisth requested a review from varunagrawal February 5, 2022 10:28
@dellaert
Copy link
Member

dellaert commented Feb 5, 2022

Thanks, clear improvement, will merge!

@dellaert dellaert merged commit efe922b into develop Feb 5, 2022
@dellaert dellaert deleted the fix/add-shared-ptr-for-camera-calibration-classes branch February 5, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

@varunagrawal varunagrawal Awaiting requested review from varunagrawal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwisth @dellaert