Remove Potentials #1013
Merged
Remove Potentials #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
approved these changes
Jan 7, 2022
| } | ||
| } | ||
|
|
||
| /* ************************************************************************* */ | ||
| double DecisionTreeFactor::safe_div(const double &a, const double &b) { | ||
| // cout << boost::format("%g / %g = %g\n") % a % b % ((a == 0) ? 0 : (a / b)); |
gtsam/discrete/Potentials.h
Outdated
| * @deprecated | ||
| * @brief Deprecated class for storing an ADT with some convenience methods | ||
| * */ | ||
| typedef GTSAM_DEPRECATED AlgebraicDecisionTree<Key> Potentials; |
There was a problem hiding this comment.
Just kill - nobody used this ever I think
gtsam/inference/BayesTree.h
Outdated
| typedef Clique Node; ///< Synonym for Clique (TODO: remove) | ||
| typedef sharedClique sharedNode; ///< Synonym for sharedClique (TODO: remove) | ||
|
|
||
| typedef GTSAM_DEPRECATED Clique Node; ///< Synonym for Clique (TODO: remove) |
There was a problem hiding this comment.
All deprecated should be at end of class in ifdef block.
varunagrawal
approved these changes
Jan 7, 2022
varunagrawal
reviewed
Jan 7, 2022
gtsam/inference/BayesTree.h
Outdated
| #ifdef GTSAM_ALLOW_DEPRECATED_SINCE_V42 | ||
| public: | ||
| typedef GTSAM_DEPRECATED Clique Node; ///< Synonym for Clique (TODO: remove) | ||
| typedef GTSAM_DEPRECATED sharedClique sharedNode; ///< Synonym for sharedClique (TODO: remove) |
There was a problem hiding this comment.
This change is the breaker. We should undo it since it is a much bigger effort which is also tangential to this PR.
There was a problem hiding this comment.
Indeed, it seems unrelated and should be it’s own PR. If it is in fact appropriate, because some of the parallel processing stuff might need this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the Potentials class and move functionalities to ADT.