Skip to content

Minor MSVC fixes #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2019
Merged

Minor MSVC fixes #44

merged 2 commits into from
Jun 4, 2019

Conversation

jlblancoc
Copy link
Member

  • -march=native is not for MSVC
  • Nicer grouping of targets in IDE "folders"

@jlblancoc jlblancoc requested a review from chrisbeall June 2, 2019 09:47
@chrisbeall
Copy link
Member

Oops! But we don't want Windows users to miss out on the huge speedup completely, so if there's no direct equivalent flag, then we should try to enable AVX, FMA, etc. directly? Something like this maybe?

CHECK_CXX_COMPILER_FLAG("/arch:AVX" COMPILER_OPT_ARCH_AVX_SUPPORTED)
if(COMPILER_OPT_ARCH_AVX_SUPPORTED)
    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /arch:AVX")
endif()

@dellaert
Copy link
Member

dellaert commented Jun 4, 2019

I will merge, I propose we leave the windows improvements for another PR.

@dellaert dellaert merged commit f2e3e81 into develop Jun 4, 2019
@dellaert dellaert deleted the minor_msvc_fixes branch June 4, 2019 02:14
@jlblancoc jlblancoc restored the minor_msvc_fixes branch December 16, 2019 14:07
@jlblancoc jlblancoc deleted the minor_msvc_fixes branch December 16, 2019 16:16
varunagrawal added a commit that referenced this pull request Apr 14, 2022
@varunagrawal
Merge pull request #44 from varunagrawal/functional-pruning
f58fbe0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisbeall chrisbeall Awaiting requested review from chrisbeall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlblancoc @chrisbeall @dellaert