Skip to content
This repository was archived by the owner on Jan 21, 2022. It is now read-only.

Fix Docker images #179

Merged
merged 8 commits into from
Dec 30, 2018
Merged

Fix Docker images #179

merged 8 commits into from
Dec 30, 2018

Conversation

jangrewe
Copy link
Contributor

@jangrewe jangrewe commented Nov 25, 2018 •
edited
Loading

This decreases the image size from nearly 900 MB to around 10MB and fixes the magneticow image (go-bindata error).

@jangrewe jangrewe mentioned this pull request Nov 25, 2018
Closed
@jangrewe jangrewe changed the title Use multi-stage build for Docker images Fix Docker images Nov 25, 2018
boramalper
boramalper suggested changes Dec 30, 2018
View reviewed changes
Copy link
Owner

@boramalper boramalper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for the changes, especially fixing docker images! I've left 2 comments, which if you can address, I'll merge ASAP. =)

@boramalper boramalper mentioned this pull request Dec 30, 2018
Closed
@boramalper boramalper merged commit 786c72c into boramalper:master Dec 30, 2018
@boramalper
Copy link
Owner

Congrats on becoming a contributor! =)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@boramalper boramalper boramalper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jangrewe @boramalper