Improves IP address detection #1051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhances IP address retrieval to accommodate hosts that do not populate standard $_SERVER variables correctly. This ensures reliable IP detection across a wider range of server configurations.
When multiple IPs are present in the X-Forwarded-For header, prioritizes the first IP address. This ensures the correct user IP is retrieved in environments with complex proxy setups.
|
@crftwrk We could think of putting the IP detection behind a filter. So that people could either disable it if wanted or write their own custom logic if needed. As of now, I assume that should fix it for most people. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances IP address retrieval to accommodate hosts that do not populate standard $_SERVER variables correctly.
This ensures reliable IP detection across a wider range of server configurations.
Discussion: https://github.com/orgs/bootscore/discussions/1049,