Feature/ajax login #1010
Feature/ajax login #1010
Conversation
Moves the AJAX login functionality for WooCommerce into separate JavaScript and PHP files. This allows for easier exclusion of the login script when not needed, improving page load times and performance. It also enhances code organization and maintainability by separating concerns.
Moves the AJAX login functionality for WooCommerce into separate JavaScript and PHP files. This allows for easier exclusion of the login script when not needed, improving page load times and performance. It also enhances code organization and maintainability by separating concerns.
…hanged in this PR
|
@Axos11 @MarkusKab Thank you, this is hot! We need to do some changes before merging. Tried to do them directly in this PR but I have no permission to change files. So, I created a PR to your branch risingBYTES#1. If you agree, please merge it, then your PR will be updated. Check https://dev.bootscore.me, just type something into the login form and click the login button. This PR does following:
LoaderIf you have a slow connection, then login offcanvas opens empty and it need some seconds to show the form. When you click the Login button, it seems that nothing happens. But we have to tell the user that something happens when offcanvas is open and when clicked the Login button.
Now, when open the offcanvas or clicking the login button, a loader is shown to tell the user that there is something in progress. Please review the files and if you agree, merge it into your branch. Feel free to make changes, you have the permission for that. When done, we should test this on some live sites for one week and share links to them before merging your PR into the theme. Just for the docsNew Action: <?php do_action( 'bootscore_before_my_offcanvas_account' ); ?>New Filter: /*
* Disable AJAX login
*/
add_filter('bootscore/wc_ajax_login', '__return_false');Agree with this changes? |
Delete unwanted files, add a loader and reformat to 2 spaces - todo -- check translations in js -- move notification on error to offcanvas only -- try to use the loader on offcanvas only
|
@Axos11 thanks for merging. Have installed this here for testing: Let's test this for at least one week before merging in to the theme.
If you have this installed on live sites as well, please share links. |
Refactors the AJAX login functionality to enhance the loading experience and simplify the logic. - Uses CSS to only show loader in offcanvas. - Only loads the account content once after opening the offcanvas. - Adds loader only during initial form loading. - Simplifies loader management for improved clarity.
Docs