Fix nested array comparison in matchExtends to prevent array-to-string conversion warnings #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g conversion warnings Fixed an issue where the use of array_diff on nested arrays caused PHP "Array to string conversion" warnings. We introduced a new method, arrays_are_equal_recursive, that recursively compares both flat and nested arrays, ensuring that valid comparisons are made without triggering errors. This ensures that even complex, nested array structures are handled correctly while maintaining the integrity of the comparison logic in matchExtends. By replacing the flat array checks with a recursive comparison method, we resolved the issue without skipping valid comparisons, ensuring robustness and preventing potential logic gaps. This update follows best practices by keeping the array comparison logic modular and reusable, promoting maintainability and reducing the risk of future errors in complex array operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the use of array_diff on nested arrays caused PHP "Array to string conversion" warnings. We introduced a new method, arrays_are_equal_recursive, that recursively compares both flat and nested arrays, ensuring that valid comparisons are made without triggering errors. This ensures that even complex, nested array structures are handled correctly while maintaining the integrity of the comparison logic in matchExtends.
By replacing the flat array checks with a recursive comparison method, we resolved the issue without skipping valid comparisons, ensuring robustness and preventing potential logic gaps. This update follows best practices by keeping the array comparison logic modular and reusable, promoting maintainability and reducing the risk of future errors in complex array operations.
Admin edit: Closes #801, See scssphp/scssphp#606 (comment), scssphp/scssphp#728