Skip to content

Conversation

cgwalters
Copy link
Collaborator

Prep for work on the composefs-rs backend.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the composefs-rs dependency to a newer revision. The changes are mostly in Cargo.lock to reflect the updated dependency tree. The code change in lib/src/cli.rs is a nice improvement, using a new to_hex() method from the updated dependency.

I've pointed out one medium-severity issue in Cargo.lock regarding the introduction of multiple versions of the rand crate, which could impact compile times and binary size. It would be good to see if these can be unified.

Copy link
Contributor

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters cgwalters enabled auto-merge July 11, 2025 20:21
@cgwalters cgwalters mentioned this pull request Jul 11, 2025
1 task
Prep for work on the composefs-rs backend.

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters cgwalters force-pushed the bump-composefs-rs branch from 9e0ffd8 to d75d539 Compare July 11, 2025 21:17
Copy link
Contributor

@allisonkarlitskaya allisonkarlitskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Happy to see the rhel9 feature getting a bit of love :)

@cgwalters cgwalters merged commit 83e93cd into bootc-dev:main Jul 12, 2025
18 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants