Skip to content
This repository was archived by the owner on Jan 1, 2021. It is now read-only.

Fix fsync on dirs in Parallels Shared Folders #1294

Merged
merged 1 commit into from
Dec 19, 2017

Conversation

romankulikov
Copy link
Contributor

Previously prl_fs didn't provide fsync handler for directory operations
(but for files did). As a result respective syscalls failed. That
caused, for example, problems with running PostgreSQL in containers over
database on a shared volume.

This patch is really a kludge to workaround the issue. And should be
removed when Parallels Tools with fixed prl_fs is incorporated.

Parallels/docker-machine-parallels#71

Previously prl_fs didn't provide fsync handler for directory operations
(but for files did). As a result respective syscalls failed. That
caused, for example, problems with running PostgreSQL in containers over
database on a shared volume.

This patch is really a kludge to workaround the issue. And should be
removed when Parallels Tools with fixed prl_fs is incorporated.

Parallels/docker-machine-parallels#71
@tianon
Copy link
Contributor

tianon commented Dec 18, 2017

Any idea what the timeframe looks like on an upstream fix? This seems OK in the interim, but we haven't had a Parallels Tools update in a long time (and I can't seem to find any reference online which would help us update to a newer version even if one were available, given that directory browsing on download.parallels.com is disabled), so I'm just concerned we'll be carrying this kludge for a long time. 😞

@romankulikov
Copy link
Contributor Author

Any idea what the timeframe looks like on an upstream fix?

Sorry, no official timeframes from Parallels.

This seems OK in the interim, but we haven't had a Parallels Tools update in a long time (and I can't seem to find any reference online which would help us update to a newer version even if one were available, given that directory browsing on download.parallels.com is disabled), so I'm just concerned we'll be carrying this kludge for a long time

I want to note here that from version 12.1.3 (which is used currently in boot2docker) to the latest 13.2.0 (to the moment) there were no any significant improvements on the Parallels Tools side for boot2docker. The most changes were done on the host side of Parallels Desktop. So updating Parallels Tools wouldn't get any real benefit. Much better for the end users to upgrade their Parallels Desktop instances on their Macs.

But sure I'm going provide pull request with the version of Parallels Tools which will contain fix of fsync issue and get rid of the kludge.

@romankulikov
Copy link
Contributor Author

Can someone point why did build check fail? I've tried to reproduce it several times in different environments but with no luck – all builds are ok.

@tianon
Copy link
Contributor

tianon commented Dec 19, 2017

The Travis failure is harmless -- if it builds successfully locally, you're good. The build takes so long that often Travis will fail simply due to that. 😄

Thanks for the additional information. ❤️

This looks good! 👍

@tianon tianon merged commit f2f9349 into boot2docker:master Dec 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants