Handle implicit fallthrough warn on no-except #674
Conversation
|
See #673 |
|
I guess it's time to upgrade the CI system too. Ubuntu Focal will be removed by Github next week... |
Fair enough. Thanks @mborland. What do you think we should do with all those tests? Should we put them on ubuntu-latest. or 22.04? Should we simply drop them? Cc: @jzmaddock |
Intuitively, I would bring all the focal tests onto 24.04 (ubuntu-latest) and run them with GCC 13. Thoughts? |
|
I've been putting all the new libs on runners copied and pasted from the Boostorg/boost-ci repo. These run latest as the host and everything else in containers. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #674 +/- ##
=======================================
Coverage 94.1% 94.1%
=======================================
Files 279 279
Lines 28983 28983
=======================================
Hits 27257 27257
Misses 1726 1726
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
The fix is fine, but I have a hunch will generate "unreachable code" warnings when building with exceptions ON. Maybe put those lines inside a #if block? Annoying I know.... |
Yep, goti it. I will be super-sure to decorate with the PP so that no corollary warnings arise. Nice point John (@jzmaddock). Will hit this after the CI blitz subsides... |
|
Drone is way too long. Whatever on earth is running there, we need to reduce the scope of testing on that thing. I'm looking for half an hour or less. This multi-hour thing isn't how it's supposed to work. I'll try to figure out what's taking forever there, and reduce the cycles. But that'll be after this PR. Cc: @mborland and @jzmaddock |
|
It looks like you're waiting on s390x runners. They are in pretty limited supply, but generally available. 26 mins is the longest single runner that's complete. Let me ping the guy that manages drone. |
Ah thanks Matt (@mborland) I hadn't thought of that exactly. Are you waiting for run-time to trickle through, ... Either way, it's a lag-time that quite honestly needs to be critically examined and weighed regarding added value or lack thereof WRT costs and time. |
|
Waiting for the runner to even start. I'm willing to bet it's related to release going out today since every boost library is showing recently updated. Basically DDoSed drone. |
10-4. |
No description provided.