Skip to content

Don't use deprecated form of user-defined literal operator around BOOST_JOIN #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

Don't use deprecated form of user-defined literal operator around BOOST_JOIN #665

merged 1 commit into from
Mar 18, 2025

Conversation

Romain-Geissler-1A
Copy link
Contributor

Hi,

I am working in @Thomas-Barbier-1A team, there is an additional fix needed to fully fix the issue #663 and merged into master with #664, the one around the BOOST_JOIN construction.

To reproduce, you just need a clang 20 compiler, which doesn't consider boost as "system header" (as otherwise all warnings are silently ignored), and create dummy plop.cpp file containing just that:

#include "boost/multiprecision/cpp_int.hpp"

Then a simple compilation like this:

rgeissler@ncerndobedev6097:~/wk/tmp> /opt/1A/toolchain/x86_64-v23/bin/clang++ -I /data/mwrep/res/osp/Boost/23-0-0-5/include -o plop.o -c plop.cpp

Will give some errors like this:

/data/mwrep/res/osp/Boost/23-0-0-5/include/boost/multiprecision/cpp_int/literals.hpp:270:1: warning: identifier '_cppi128' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator] 
  270 | BOOST_MP_DEFINE_SIZED_CPP_INT_LITERAL(128)
      | ^
/data/mwrep/res/osp/Boost/23-0-0-5/include/boost/multiprecision/cpp_int/literals.hpp:254:199: note: expanded from macro 'BOOST_MP_DEFINE_SIZED_CPP_INT_LITERAL'
  254 |    constexpr boost::multiprecision::number<boost::multiprecision::backends::cpp_int_backend<Bits, Bits, boost::multiprecision::signed_magnitude, boost::multiprecision::unchecked, void> > operator"" BOOST_JOIN(_cppi, Bits)()    \ 
      |                                                                                                                                                                                                       ^
/data/mwrep/res/osp/Boost/23-0-0-5/include/boost/config/helper_macros.hpp:33:26: note: expanded from macro 'BOOST_JOIN'
   33 | #define BOOST_JOIN(X, Y) BOOST_DO_JOIN(X, Y)
      |                          ^
/data/mwrep/res/osp/Boost/23-0-0-5/include/boost/config/helper_macros.hpp:34:29: note: expanded from macro 'BOOST_DO_JOIN'
   34 | #define BOOST_DO_JOIN(X, Y) BOOST_DO_JOIN2(X,Y)
      |                             ^
/data/mqwrep/res/osp/Boost/23-0-0-5/include/boost/config/helper_macros.hpp:35:30: note: expanded from macro 'BOOST_DO_JOIN2'
   35 | #define BOOST_DO_JOIN2(X, Y) X##Y
      |                              ^
<scratch space>:98:1: note: expanded from here
   98 | _cppi128
      | ^
In file included from plop.cpp:1:
In file included from /data/mwrep/res/osp/Boost/23-0-0-5/include/boost/multiprecision/cpp_int.hpp:2344:

@codecov Codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (c42d8a9) to head (2ed2ef7).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #665     +/-   ##
=========================================
+ Coverage     94.1%   94.1%   +0.1%     
=========================================
  Files          279     279             
  Lines        28979   28979             
=========================================
+ Hits         27253   27255      +2     
+ Misses        1726    1724      -2
Files with missing lines Coverage Δ
include/boost/multiprecision/cpp_int/literals.hpp 100.0% <ø> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c42d8a9...2ed2ef7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jzmaddock jzmaddock merged commit 7fac807 into boostorg:develop Mar 18, 2025
79 checks passed
@jzmaddock jzmaddock mentioned this pull request Mar 24, 2025
Merged
@mborland mborland mentioned this pull request Apr 25, 2025
Closed
@ckormanyos ckormanyos mentioned this pull request Apr 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Romain-Geissler-1A @jzmaddock