Skip to content

Add support for modular build structure. #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Jun 10, 2025
Merged

Add support for modular build structure. #632

merged 32 commits into from
Jun 10, 2025

Conversation

grafikrobot
Copy link
Member

@grafikrobot grafikrobot commented Jul 20, 2024 •
edited
Loading

This is part of the effort to make the Boost libraries "modular" for build and consumption. See https://lists.boost.org/Archives/boost/2024/01/255704.php and https://github.com/grafikrobot/boost-b2-modular/blob/b2-modular/README.adoc for more information.

This PR depends on the following other PRs being merged to both develop and master branches of the respective repos:

This PR will be changed to ready for review, i.e. not draft, when the above are merged. Do not merge this one until that time.

@grafikrobot
Make the library modular usable.
3034224
@grafikrobot
Switch to library requirements instead of source. As source puts extr…
7003efd 
…a source in install targets.
@grafikrobot
Sync from upstream.
d489233
@grafikrobot
Add missing import-search for cconfig/predef checks.
ef77072
@grafikrobot
Sync from upstream.
1116383
@grafikrobot
Add requires-b2 check to top-level build file.
8bac494
@grafikrobot
Bump B2 require to 5.2
6862981
@grafikrobot
Sync from upstream.
22be128
@grafikrobot
Sync from upstream.
c099480
@grafikrobot
Change all <source> references to <library>.
fb9fc0c
@grafikrobot
Update copyright dates.
6ff916d
@grafikrobot
Move inter-lib dependencies to a project variable and into the build …
882555f 
…targets.
@grafikrobot
Sync from upstream.
c6199c9
@grafikrobot
Adjust doc build to avoid boost-root references.
48e4bc0
@grafikrobot
Update build deps.
655d438
@grafikrobot
Change Boost Test build refs to work with both old and modular test l…
4207037 
…ib targets.
@grafikrobot
Sync from upstream.
5641f21
@grafikrobot
Copy link
Member Author

Toggling to refresh build now that the deps are available.

@grafikrobot grafikrobot reopened this Sep 14, 2024
@jzmaddock
Copy link
Collaborator

@grafikrobot is this ready now? Do we know what the CI failures are?

@codecov Codecov
Copy link

codecov bot commented Apr 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (96eb274) to head (18969f4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #632     +/-   ##
=========================================
- Coverage     94.1%   94.1%   -0.0%     
=========================================
  Files          280     280             
  Lines        29074   29074             
=========================================
- Hits         27349   27347      -2     
- Misses        1725    1727      +2
Files with missing lines Coverage Δ
test/test_arithmetic_complex128.cpp 100.0% <ø> (ø)
test/test_arithmetic_complex_adaptor.cpp 100.0% <ø> (ø)
test/test_arithmetic_complex_adaptor_2.cpp 100.0% <ø> (ø)
test/test_arithmetic_cpp_bin_float_1.cpp 100.0% <ø> (ø)
test/test_arithmetic_cpp_bin_float_2.cpp 100.0% <ø> (ø)
test/test_arithmetic_cpp_bin_float_2m.cpp 100.0% <ø> (ø)
test/test_arithmetic_cpp_bin_float_3.cpp 100.0% <ø> (ø)
test/test_arithmetic_cpp_bin_float_4.cpp 100.0% <ø> (ø)
test/test_arithmetic_cpp_bin_float_5.cpp 100.0% <ø> (ø)
test/test_arithmetic_cpp_bin_float_6.cpp 100.0% <ø> (ø)
... and 2 more

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96eb274...18969f4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grafikrobot
Copy link
Member Author

@grafikrobot is this ready now? Do we know what the CI failures are?

I tried to fix the latest CircleCI failure from the inspect change. Unfortunately I can't fix ICE errors from trying to build the doc tools.

I don't know what the Windows failures are. I'm still investigating them.

@grafikrobot grafikrobot closed this Jun 9, 2025
@grafikrobot grafikrobot reopened this Jun 9, 2025
@grafikrobot grafikrobot marked this pull request as ready for review June 10, 2025 00:07
@grafikrobot
Copy link
Member Author

@jzmaddock I finally figured out the issue with the Windows builds. For not an entirely known reason the GMP config check was succeeding on Windows with the use of searched-lib gmp. I reverted those changes as they where for a n0 longer needed workaround.

@mborland
Copy link
Member

CircleCI error is known and unrelated with PR here: #687

@mborland mborland merged commit 6df8e19 into boostorg:develop Jun 10, 2025
79 of 80 checks passed
jzmaddock
jzmaddock reviewed Jun 10, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzmaddock jzmaddock jzmaddock left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grafikrobot @jzmaddock @mborland