-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Backports for 3.0.3 #12662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Backports for 3.0.3 #12662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Neutral POV for install instructions * Update README.md Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com> Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com>
* apply fixes * stricter, more fixes * more fixes, check __init__.py better * remove flake8 * add U amd W checks * combine imports
LGTM service will shut down in a few weeks. https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/#end-of-november-new-commits-and-pull-requests-are-no-longer-analyzed
* Added metadata to glyphs.py, multi_legend.py, multi_scale.py * Removed trailing whitespaces. * Pared down apis to the most interesting and put it in a single line. * Added the apis in a single line and updated the keywords.
* pydot -> pygraphviz * remove publish_display_data source param
* exlude tmp files from coverage * silence linter
* Update CodeQL action * kick the tires
* Updates to docker image building * Support all non-firefox tests in docker container * Try ECR upload * Update ECR region and repository * Chromedriver version does not have to match chrome version * Try ECR upload * Try adding custom registry alias * try default registry alias * Try default alias take 2 * specify public registry login * fix registry type config * Try dockerhub * fix typo * Try multiple tags * Option to push or save image * Github action to run tests in docker container * Temporarily force BokehJS-CI to run * Try to get docker testing to run in CI * Run docker in CI using wheel * Use entrypoint script to install from wheel * Final tweaks * Switch to docker testing using image named branch-3.1 * Add test running chromium in Docker without required envvar * Move test-in-docker to separate workflow * Better docker CI names Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
* Added find_stack_level to util.deprecation * Moving deprecation -> warnings * Change to use internal warn * Fix import * Fix lint * Fix failing test
* Use type[T] instead of Type[T] where permitted * Pin ruff to last working version (0.0.144)
* fix broken bokeh-tree links * fix broken metadata ref * more versioned links * lint
* remove API import lint hack in properties.py * remove API import lint hack in plotting/__init__.py * remove API import lint hack in sampledata/__init__.py * remove API import lint hack in document/__init__.py * remove API import lint hack in embed/util.py * remove API import lint hack in top level __init__.py * remove API import lint hack in model/util.py * clean up doc event imports * clean up defaults tests imports * remove non-functional spec.py * review changes
* Add default styles to FILE template * Don't ignore template files * Skip stocks and surface3d examples
Codecov Report
@@ Coverage Diff @@
## branch-3.0 #12662 +/- ##
==============================================
+ Coverage 92.12% 92.16% +0.03%
==============================================
Files 312 312
Lines 19558 19579 +21
==============================================
+ Hits 18018 18045 +27
+ Misses 1540 1534 -6 |
* Ensure change callback manipulation is threadsafe The `_change_callbacks` dictionary is being iterated over directly which means that when another thread removes or adds a callback we get `RuntimeError: dictionary changed size during iteration`. This PR simply makes a copy of the dictionary so we can iterate over it safely. * Also handle event callbacks * factor callback lookup into methods returning tuples Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs:
plus commits: