Compute layout for initially undisplayed components #12653

mattpap · 2022-11-29T16:12:02Z

bokehjs/test/unit/models/canvas/canvas.ts

bryevdv · 2022-11-29T16:24:26Z

Confirm this change fixes the MRE in #12640

codecov · 2022-11-29T16:41:24Z

Codecov Report

Merging #12653 (e91e9f9) into branch-3.1 (8fa898b) will increase coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           branch-3.1   #12653   +/-   ##
===========================================
  Coverage       92.16%   92.16%           
===========================================
  Files             313      313           
  Lines           19570    19584   +14     
===========================================
+ Hits            18036    18050   +14     
  Misses           1534     1534

bryevdv · 2022-11-29T17:25:57Z

Assuming you don't want to make the U00X suggested updates in this PR, those rules can be disabled here:

bokeh/pyproject.toml

Lines 117 to 122 in 829a9d0

    
           select = ["E", "F", "M", "U", "W"] 
        
           ignore = [ 
        
               'E402', # Module level import not at top of file 
        
               'E731', # Do not assign a lambda expression, use a def 
        
               'E741', # Ambiguous variable name: I 
        
           ]

(Either remove "U" altogether or ignore specific rules)

Edit: if you do want to apply them, ruff --fix . will fix all but two issues.

mattpap · 2022-11-29T18:04:57Z

Given that pyproject.toml contains target-version = "py38" for ruff, then most of those errors don't make sense. This must be some kind of regression in ruff. I will pin it the the last working version, which we should have done anyway, because we shouldn't be updating code quality in random PRs.

mattpap · 2022-11-29T18:10:28Z

For example this:

-TypeOrInst: TypeAlias = Union[Type[T], T]
+TypeOrInst: TypeAlias = type[T] | T
 
-Init: TypeAlias = Union[T, UndefinedType, IntrinsicType]
+Init: TypeAlias = T | UndefinedType | IntrinsicType

will fail in 3.8, 3.9.

bryevdv · 2022-11-29T18:21:34Z

I will pin it the the last working version, which we should have done anyway, because we shouldn't be updating code quality in random PRs.

👍 This seems advised. FWIW the ruff dev is very responsive, if you want to submit an issue it will likely be addressed quickly.

bryevdv · 2022-11-29T21:45:33Z

@mattpap do you know if this is the fix for the Dask issue? As soon as that is in, I plan to make a 3.0.4 release for them

bokeh 3.0.4 should in theory fix this (bokeh/bokeh#12653). See bug report here: bokeh/bokeh#12614

mattpap · 2022-11-30T00:52:17Z

It may help in some cases, but not the reported ones.

bokeh 3.0.4 should in theory fix this (bokeh/bokeh#12653). See bug report here: bokeh/bokeh#12614

* Neutral POV for install instructions (#12603) * Neutral POV for install instructions * Update README.md Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com> Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com> * Fix export with fractional CSS lengths (#12613) * Fix layout propagation in nested mixed layouts (#12612) * Replace flake8 with ruff (#12605) * apply fixes * stricter, more fixes * more fixes, check __init__.py better * remove flake8 * add U amd W checks * combine imports * remove spurious # noqa * Remove LGTM (#12620) LGTM service will shut down in a few weeks. https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/#end-of-november-new-commits-and-pull-requests-are-no-longer-analyzed * Added metadata to glyphs.py, multi_legend.py, multi_scale.py (#12547) * Added metadata to glyphs.py, multi_legend.py, multi_scale.py * Removed trailing whitespaces. * Pared down apis to the most interesting and put it in a single line. * Added the apis in a single line and updated the keywords. * Bv/deprecated apis in tests (#12622) * pydot -> pygraphviz * remove publish_display_data source param * Exlude tmp files from coverage (#12629) * exlude tmp files from coverage * silence linter * Update CodeQL action (#12630) * Update CodeQL action * kick the tires * Fix application of UI element styles in Firefox (#12634) * Add CodeQL config (#12636) * codeql config in proper job * Updates to Docker image building and testing (#12351) * Updates to docker image building * Support all non-firefox tests in docker container * Try ECR upload * Update ECR region and repository * Chromedriver version does not have to match chrome version * Try ECR upload * Try adding custom registry alias * try default registry alias * Try default alias take 2 * specify public registry login * fix registry type config * Try dockerhub * fix typo * Try multiple tags * Option to push or save image * Github action to run tests in docker container * Temporarily force BokehJS-CI to run * Try to get docker testing to run in CI * Run docker in CI using wheel * Use entrypoint script to install from wheel * Final tweaks * Switch to docker testing using image named branch-3.1 * Add test running chromium in Docker without required envvar * Move test-in-docker to separate workflow * Better docker CI names Co-authored-by: Bryan Van de Ven <bryan@bokeh.org> * Disable docker from wheel integration tests (#12639) * Added find_stack_level to util.warnings (#12650) * Added find_stack_level to util.deprecation * Moving deprecation -> warnings * Change to use internal warn * Fix import * Fix lint * Fix failing test * Resolve issues with code quality checks (#12654) * Use type[T] instead of Type[T] where permitted * Pin ruff to last working version (0.0.144) * Compute layout for initially undisplayed components (#12653) * Fix broken bokeh-tree links (#12644) * fix broken bokeh-tree links * fix broken metadata ref * more versioned links * lint * CodeQL: remove import linter hack (#12645) * remove API import lint hack in properties.py * remove API import lint hack in plotting/__init__.py * remove API import lint hack in sampledata/__init__.py * remove API import lint hack in document/__init__.py * remove API import lint hack in embed/util.py * remove API import lint hack in top level __init__.py * remove API import lint hack in model/util.py * clean up doc event imports * clean up defaults tests imports * remove non-functional spec.py * review changes * Add default styles to FILE template (#12656) * Add default styles to FILE template * Don't ignore template files * Skip stocks and surface3d examples * Adapt Bokeh logo for dark theme and add docs badge in README.md (#12659) Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com> Co-authored-by: Mateusz Paprocki <mattpap@gmail.com> Co-authored-by: Yash Pratapwar <65851650+Yash-Pratapwar@users.noreply.github.com> Co-authored-by: Ian Thomas <ianthomas23@gmail.com> Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com> Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>

github-actions · 2024-10-26T04:10:53Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Compute layout for initially undisplayed components

e91e9f9

mattpap added the status: ready label Nov 29, 2022

mattpap added this to the 3.1 milestone Nov 29, 2022

bryevdv reviewed Nov 29, 2022

View reviewed changes

bokehjs/test/unit/models/canvas/canvas.ts Show resolved Hide resolved

bryevdv approved these changes Nov 29, 2022

View reviewed changes

mattpap added status: accepted and removed status: ready labels Nov 29, 2022

mattpap merged commit c14de0c into branch-3.1 Nov 29, 2022

mattpap deleted the mattpap/12640_layout_undisplayed branch November 29, 2022 20:04

andrew-platt added a commit to andrew-platt/openfast that referenced this pull request Nov 29, 2022

CI: exclude bokeh 3.0.[0-3] -- broken plots

674c150

bokeh 3.0.4 should in theory fix this (bokeh/bokeh#12653). See bug report here: bokeh/bokeh#12614

andrew-platt mentioned this pull request Nov 29, 2022

CI: exclude bokeh 3.0.[0-3] -- broken plots OpenFAST/openfast#1357

Merged

andrew-platt added a commit to OpenFAST/openfast that referenced this pull request Nov 30, 2022

CI: exclude bokeh 3.0.[0-3] -- broken plots

785bd1d

bokeh 3.0.4 should in theory fix this (bokeh/bokeh#12653). See bug report here: bokeh/bokeh#12614

mcrot mentioned this pull request Dec 2, 2022

NaN cannot be represented in JSON ContactEngineering/topobank#932

Closed

bryevdv pushed a commit that referenced this pull request Dec 6, 2022

Compute layout for initially undisplayed components (#12653)

13ca81a

This was referenced Dec 6, 2022

Backports for 3.0.3 #12662

Merged

U00X rules ignoring target-version astral-sh/ruff#1113

Closed

bryevdv modified the milestones: 3.1, 3.0.3 Dec 7, 2022

Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024

Compute layout for initially undisplayed components (bokeh#12653)

3583d34

github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Compute layout for initially undisplayed components #12653

Compute layout for initially undisplayed components #12653

Uh oh!

mattpap commented Nov 29, 2022

Uh oh!

Uh oh!

bryevdv commented Nov 29, 2022

Uh oh!

codecov bot commented Nov 29, 2022 •

edited

Loading

Uh oh!

bryevdv commented Nov 29, 2022 •

edited

Loading

Uh oh!

mattpap commented Nov 29, 2022

Uh oh!

mattpap commented Nov 29, 2022

Uh oh!

bryevdv commented Nov 29, 2022

Uh oh!

bryevdv commented Nov 29, 2022

Uh oh!

mattpap commented Nov 30, 2022

Uh oh!

github-actions bot commented Oct 26, 2024

Uh oh!

Uh oh!

Uh oh!

Compute layout for initially undisplayed components #12653

Compute layout for initially undisplayed components #12653

Uh oh!

Conversation

mattpap commented Nov 29, 2022

Uh oh!

Uh oh!

bryevdv commented Nov 29, 2022

Uh oh!

codecov bot commented Nov 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bryevdv commented Nov 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mattpap commented Nov 29, 2022

Uh oh!

mattpap commented Nov 29, 2022

Uh oh!

bryevdv commented Nov 29, 2022

Uh oh!

bryevdv commented Nov 29, 2022

Uh oh!

mattpap commented Nov 30, 2022

Uh oh!

github-actions bot commented Oct 26, 2024

Uh oh!

Uh oh!

codecov bot commented Nov 29, 2022 •

edited

Loading

bryevdv commented Nov 29, 2022 •

edited

Loading