Skip to content

Conversation

bryevdv
Copy link
Member

@bryevdv bryevdv commented Nov 20, 2022

This PR updates the CodeQL action to mirror the automated PR submitted by GitHub to jupyter_bokeh (bokeh/jupyter_bokeh#173). Specifically, this brings in the code quality checks that used to be part of LGTM, but also updates other actions to latest versions.

@bryevdv bryevdv added this to the 3.1 milestone Nov 20, 2022
@bryevdv
Copy link
Member Author

bryevdv commented Nov 20, 2022

Well I guess this will have to be merged to see the checks run.

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #12630 (8258a36) into branch-3.1 (04fa9f4) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           branch-3.1   #12630      +/-   ##
==============================================
- Coverage       92.16%   92.16%   -0.01%     
==============================================
  Files             313      312       -1     
  Lines           19562    19560       -2     
==============================================
- Hits            18030    18027       -3     
- Misses           1532     1533       +1     

@bryevdv bryevdv merged commit 28bf3fe into branch-3.1 Nov 20, 2022
@mattpap mattpap deleted the bv/update-codeql branch November 20, 2022 20:11
@bryevdv
Copy link
Member Author

bryevdv commented Nov 20, 2022

OK it ran on merge and made ~900 observations. Before you comment @mattpap I will be going through them to figure out which are valid and need fixed (definitely several from a glance), and which should be ignore either via comment or configuration, over the next week.

bryevdv added a commit that referenced this pull request Dec 6, 2022
* Update CodeQL action

* kick the tires
@bryevdv bryevdv mentioned this pull request Dec 6, 2022
bryevdv added a commit that referenced this pull request Dec 7, 2022
* Neutral POV for install instructions (#12603)

* Neutral POV for install instructions

* Update README.md

Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com>

Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com>

* Fix export with fractional CSS lengths (#12613)

* Fix layout propagation in nested mixed layouts (#12612)

* Replace flake8 with ruff (#12605)

* apply fixes

* stricter, more fixes

* more fixes, check __init__.py better

* remove flake8

* add U amd W checks

* combine imports

* remove spurious # noqa

* Remove LGTM (#12620)

LGTM service will shut down in a few weeks. 

https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/#end-of-november-new-commits-and-pull-requests-are-no-longer-analyzed

* Added metadata to glyphs.py, multi_legend.py, multi_scale.py (#12547)

* Added metadata to glyphs.py, multi_legend.py, multi_scale.py

* Removed trailing whitespaces.

* Pared down apis to the most interesting and put it in a single line.

* Added the apis in a single line and updated the keywords.

* Bv/deprecated apis in tests (#12622)

* pydot -> pygraphviz

* remove publish_display_data source param

* Exlude tmp files from coverage (#12629)

* exlude tmp files from coverage

* silence linter

* Update CodeQL action (#12630)

* Update CodeQL action

* kick the tires

* Fix application of UI element styles in Firefox (#12634)

* Add CodeQL config (#12636)

* codeql config in proper job

* Updates to Docker image building and testing (#12351)

* Updates to docker image building

* Support all non-firefox tests in docker container

* Try ECR upload

* Update ECR region and repository

* Chromedriver version does not have to match chrome version

* Try ECR upload

* Try adding custom registry alias

* try default registry alias

* Try default alias take 2

* specify public registry login

* fix registry type config

* Try dockerhub

* fix typo

* Try multiple tags

* Option to push or save image

* Github action to run tests in docker container

* Temporarily force BokehJS-CI to run

* Try to get docker testing to run in CI

* Run docker in CI using wheel

* Use entrypoint script to install from wheel

* Final tweaks

* Switch to docker testing using image named branch-3.1

* Add test running chromium in Docker without required envvar

* Move test-in-docker to separate workflow

* Better docker CI names

Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>

* Disable docker from wheel integration tests (#12639)

* Added find_stack_level to util.warnings (#12650)

* Added find_stack_level to util.deprecation

* Moving deprecation -> warnings

* Change to use internal warn

* Fix import

* Fix lint

* Fix failing test

* Resolve issues with code quality checks (#12654)

* Use type[T] instead of Type[T] where permitted

* Pin ruff to last working version (0.0.144)

* Compute layout for initially undisplayed components (#12653)

* Fix broken bokeh-tree links (#12644)

* fix broken bokeh-tree links

* fix broken metadata ref

* more versioned links

* lint

* CodeQL: remove import linter hack (#12645)

* remove API import lint hack in properties.py

* remove API import lint hack in plotting/__init__.py

* remove API import lint hack in sampledata/__init__.py

* remove API import lint hack in document/__init__.py

* remove API import lint hack in embed/util.py

* remove API import lint hack in top level __init__.py

* remove API import lint hack in model/util.py

* clean up doc event imports

* clean up defaults tests imports

* remove non-functional spec.py

* review changes

* Add default styles to FILE template (#12656)

* Add default styles to FILE template

* Don't ignore template files

* Skip stocks and surface3d examples

* Adapt Bokeh logo for dark theme and add docs badge in README.md (#12659)

Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com>
Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>
Co-authored-by: Yash Pratapwar <65851650+Yash-Pratapwar@users.noreply.github.com>
Co-authored-by: Ian Thomas <ianthomas23@gmail.com>
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
@bryevdv bryevdv modified the milestones: 3.1, 3.0.3 Dec 7, 2022
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
* Update CodeQL action

* kick the tires
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant